Support for Iceberg from YAML via ManagedIO. #33579
Merged
+147
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @ahmedabu98 |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
robertwb
force-pushed
the
yaml-iceberg
branch
from
b9ab37c to
26f6d28
Compare
robertwb
force-pushed
the
yaml-iceberg
branch
from
26f6d28 to
e5b4f8e
Compare
ahmedabu98
reviewed
Jan 14, 2025
Comment on lines
487
to
494
| def read_from_iceberg( | ||
| table: str, | ||
| catalog_name: Optional[str] = None, | ||
| catalog_properties: Optional[Mapping[str, str]] = None, | ||
| config_properties: Optional[Mapping[str, str]] = None, | ||
| ): | ||
| # TODO(robertwb): It'd be nice to derive these from the iceberg (or managed) | ||
| # scheams. |
There was a problem hiding this comment.
would be good to populate the parameters programmatically too
ahmedabu98
approved these changes
Jan 14, 2025
ahmedabu98
reviewed
Jan 14, 2025
| https://cloud.google.com/dataflow/docs/guides/managed-io#iceberg). | ||
|
|
||
| Args: | ||
| table: The identifier of the Apache Iceberg table. Example: "db.table1". |
There was a problem hiding this comment.
Might be good to hint that dynamic destinations is supported and link to https://cloud.google.com/dataflow/docs/guides/managed-io#dynamic-destinations
robertwb
force-pushed
the
yaml-iceberg
branch
from
82cfebb to
631a563
Compare
robertwb
force-pushed
the
yaml-iceberg
branch
from
631a563 to
239cf63
Compare
ahmedabu98
reviewed
Jan 16, 2025
|
|
||
| See also the [Apache Iceberg Beam documentation]( | ||
| https://cloud.google.com/dataflow/docs/guides/managed-io#iceberg) | ||
| and []( |
There was a problem hiding this comment.
nit: empty brackets
Suggested change
| and []( | |
| and the [dynamic destinations section]( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.